Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[588] part 2, delete One Login pre release banners flag from features #10281

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[588] part 2, delete One Login pre release banners flag from features #10281

merged 1 commit into from
Jan 28, 2025

Conversation

elceebee
Copy link
Contributor

Context

This PR removes an unused Feature flag from the code base. See earlier PR for full context.

Changes proposed in this pull request

No UI changes, just removing a feature from the database.

Guidance to review

Link to Trello card

https://trello.com/c/m4unLeJX

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee self-assigned this Jan 20, 2025
@elceebee elceebee changed the title Delete One Login pre release banners flag from features [588] part 2, delete One Login pre release banners flag from features Jan 20, 2025
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from 072f149 to 84e6633 Compare January 21, 2025 15:59
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 3a901fc to 47c246f Compare January 21, 2025 16:02
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from 84e6633 to a1bf2ab Compare January 21, 2025 16:22
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 47c246f to 0e0118b Compare January 21, 2025 16:23
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from a1bf2ab to d246dd4 Compare January 22, 2025 14:44
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 0e0118b to 57ca37a Compare January 22, 2025 14:44
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from d246dd4 to dd35f82 Compare January 28, 2025 09:13
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 57ca37a to 50d0e4b Compare January 28, 2025 09:14
@elceebee elceebee force-pushed the 588-tech-debt-revert-one-login-pre-release-comms-post-release branch from dd35f82 to cff1e94 Compare January 28, 2025 11:02
Base automatically changed from 588-tech-debt-revert-one-login-pre-release-comms-post-release to main January 28, 2025 11:46
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from 50d0e4b to 5db2b81 Compare January 28, 2025 11:47
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch 2 times, most recently from 7830d91 to e59ae61 Compare January 28, 2025 11:49
@elceebee elceebee marked this pull request as ready for review January 28, 2025 11:50
@elceebee elceebee requested review from dcyoung-dev and a team January 28, 2025 11:50
@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from e59ae61 to b1e7d6e Compare January 28, 2025 12:06
avinhurry
avinhurry approved these changes Jan 28, 2025
View reviewed changes
spec/services/data_migrations/remove_one_login_pre_release_banners_feature_flag_spec.rb
require 'rails_helper'

RSpec.describe DataMigrations::RemoveOneLoginPreReleaseBannersFeatureFlag do
context 'when the feature flag exist' do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
context 'when the feature flag exist' do
context 'when the feature flag exists' do

@elceebee elceebee force-pushed the 588-delete-pre-release-banner-feature-flag-from-db branch from b1e7d6e to 38400ec Compare January 28, 2025 16:11
@elceebee elceebee merged commit 624f4b7 into main Jan 28, 2025
23 checks passed
@elceebee elceebee deleted the 588-delete-pre-release-banner-feature-flag-from-db branch January 28, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinhurry avinhurry avinhurry approved these changes

@dcyoung-dev dcyoung-dev Awaiting requested review from dcyoung-dev

Assignees

@elceebee elceebee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elceebee @dcyoung-dev @avinhurry